fix(platforms): exclude 'games' from platforms/all.json summary#211
Merged
ReenigneArcher merged 1 commit intomasterfrom Feb 22, 2026
Merged
Conversation
Calculate and attach per-platform game counts as before, but write a lightweight platforms/all.json that omits the full 'games' lists to keep the summary file small (fits GitHub Pages limits). Adds a brief explanatory comment/docstring and builds summary_data without 'games' before calling write_json_files. Updates unit test to verify the 'games' key is not present in the written summary and that game_count and platform name remain correct.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #211 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 9 9
Lines 1042 1043 +1
=========================================
+ Hits 1042 1043 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
ReenigneArcher
deleted the
fix/platforms/don't-write-games-to-all.json
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Calculate and attach per-platform game counts as before, but write a lightweight platforms/all.json that omits the full 'games' lists to keep the summary file small (fits GitHub Pages limits). Adds a brief explanatory comment/docstring and builds summary_data without 'games' before calling write_json_files. Updates unit test to verify the 'games' key is not present in the written summary and that game_count and platform name remain correct.
Screenshot
Issues Fixed or Closed
Roadmap Issues
Type of Change
Checklist
AI Usage